Merge code that handles Adjoint and Transpose
#49521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Takafumi Arakaki <[email protected]>
dkarrasch
commented
Apr 26, 2023
Comment on lines
-403
to
-405
| @inline mul!(C::AbstractVector, A::AbstractVecOrMat, tB::Transpose{<:Any,<:AbstractVecOrMat}, | ||
| alpha::Number, beta::Number) = | ||
| generic_matmatmul!(C, 'N', 'T', A, tB.parent, MulAddMul(alpha, beta)) |
There was a problem hiding this comment.
The only change in tests is due to the removal of this method, which is at odds with all the rest of the mul! functions due to the vector target. This only works when all vectors have length 1, anyway. And there is no Adjoint analogue.
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. |
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual rebase of #33069. Some of the then proposed changes have become obsolete, and I have added a few new ones, most notably the
matmul.jlmethods. This cuts the number ofmul!methods from 114 to9088.Closes #33069.
Co-authored-by: Takafumi Arakaki [email protected]